[improve test]reboot SONiC if sanity check fail before run tset case#443
Merged
maggiemsft merged 2 commits intosonic-net:masterfrom Feb 2, 2018
Merged
Conversation
… check fail before calling test
jleveque
suggested changes
Jan 31, 2018
| - name: Verify that syncd process is running | ||
| assert: { that: "{{ psnew_out.stdout_lines | length }} > 0"} | ||
|
|
||
| - name: Get oragent process information |
Contributor
There was a problem hiding this comment.
Typo: "oragent" --> "orchagent"
|
|
||
| - debug: var=orchnew_out.stdout_lines | ||
|
|
||
| - name: Verify that orch process is running |
Contributor
There was a problem hiding this comment.
Might as well use the entire process name here ("orch" --> "orchagent").
| @@ -0,0 +1,23 @@ | |||
| - name: reboot | |||
| become: true | |||
| shell: shutdown -r now "Reboot SONiC." | |||
Contributor
There was a problem hiding this comment.
Might as well make message more descriptive, e.g.:
shutdown -r now "Warning! System is being rebooted remotely by reboot_sonic.yml."
jleveque
approved these changes
Feb 1, 2018
yxieca
approved these changes
Feb 1, 2018
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Jun 27, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR To skip test_watchdog_reboot on x3b platforms. Summary: Fixes # (issue) https://github.com/Nokia-ION/ndk/issues/90#issuecomment-2959307315 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? To skip unsupported tests. #### How did you do it? By adding the platform specific check in tests_mark_conditions_platform_tests.yaml #### How did you verify/test it? By running in MSFT Lab #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#2759) Submodule src/sonic-sairedis 483c89e..97dd2a8: > Fix compilation issues in stretch docker with gcc-6.3 (sonic-net#426) > Make object list deterministic when iterating (sonic-net#438) > Ignore ACL_COUNTER bytes and packets during comparison logic (sonic-net#443) Submodule src/sonic-swss d22b2de..ae74a27: > Survive pfc watchdog storm action across warm-reboot (sonic-net#794) Submodule src/sonic-swss-common 36fd5e9..24c0ff7: > Update PFC_WD table name in CONFIG_DB (sonic-net#266) Submodule src/sonic-utilities bae21e7..6aee909: > [neighbor advertiser] convert int to string before concatenating (sonic-net#505) > [config]: Change the order of interface commands (sonic-net#504) > Change PFC watchdog CONFIG_DB table name from PFC_WD_TABLE to PFC_WD (sonic-net#475) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…D automatically (sonic-net#18302) #### Why I did it src/sonic-platform-daemons ``` * 72e9a28 - (HEAD -> 202305, origin/202305) Enable periodic polling of TRANSCEIVER_FIRMWARE_INFO table in DomInfoUpdateTask (sonic-net#443) (sonic-net#445) (10 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
reboot SONiC DUT if sanity check or interface check fail before running test case
also move decap test parameter to within test playbook, not doing it in test_sonic_by_testname.yml
Type of change
Approach
How did you do it?
Before: When trying to run test cases continuously, one test case failure due to crashed process or brought down interfaces will cause all subsequence tests fail.
Now: If sanity check fail or interface check fail, reboot the SONiC DUT and try to bring back known good state.
Thinking of doing restart process, since the goal is to re-establish a known good state, reboot is more clean.
How did you verify/test it?
verified it in my local testing environment
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation